POC: deprecation with strict removal version #28470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
commented
Sep 16, 2019
| def strict_deprecation(msg, deprecated_in, remove_in): | ||
| def deprecator(arg): | ||
| if isinstance(arg, str): | ||
| key = arg |
There was a problem hiding this comment.
this isnt really necessary, was for a non-decorator usage I had in mind, but that is problematic since it might not run at import-time.
|
Thinking out loud but is it possible to move some of this to |
Agreed on the principle, no idea about the implementation. Maybe code_checks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #28415
Decorator that just registers the deprecation in a dict that we can check and test-time.