TST: restore type checks to maybe_promote tests #28561
Conversation
gfyoung
added
Dtype Conversions
| casted = dtype.type(value) | ||
| if casted == value: | ||
| return True | ||
| return False |
There was a problem hiding this comment.
Why not just return dtype.type(value) == value ?
There was a problem hiding this comment.
Either way would work. I think in future steps this function is going to have to check a couple more things.
Co-Authored-By: gfyoung <gfyoung17+GitHub@gmail.com>
| @@ -366,6 +367,8 @@ def maybe_promote(dtype, fill_value=np.nan): | |||
| elif is_bool(fill_value): | |||
| if not issubclass(dtype.type, np.bool_): | |||
| dtype = np.object_ | |||
| else: | |||
| fill_value = np.bool_(fill_value) | |||
There was a problem hiding this comment.
you added some code here but are these actually hit?
There was a problem hiding this comment.
i see you have another PR on top; can you just do them in one
There was a problem hiding this comment.
you added some code here but are these actually hit?
Yes. All the changes to the non-test code are needed to make the changes in the test code pass.
There was a problem hiding this comment.
i see you have another PR on top; can you just do them in one
Sure. Just close this and move conversation there?
There was a problem hiding this comment.
yeah let's just do it in one
|
Closing in favor of #28564. |
xref #25425. Working on fixing the xfailed tests in this file. This is going to be a marathon.