To html encoding add #28692

cailurus · 2019-09-30T19:35:35Z

[x ] closes to_html()没有encoding参数？造成输出中文显示乱码 #28663
[x ] tests added / passed
[x ] passes black pandas
[x ] passes git diff upstream/master -u -- "*.py" | flake8 --diff
[x ] whatsnew entry

added encoding argument to DataFrame.to_html()

pandas/core/frame.py

cailurus · 2019-09-30T20:44:43Z

hi @josibake , I found two checks failed but I just got [error]Bash exited with code '1' in azure log, could you give me some tips to fix this?

josibake · 2019-09-30T20:56:42Z

hey @ailurus1991 , if you look further up in the logs, it says that running black changed two files.

try running black pandas/core commit those changes.

WillAyd

Can you add a test for this - typically the first thing we would look at in review

WillAyd

Thanks. Looks pretty good some minor questions. Can you also add a whatsnew for v1.0.0?

pandas/tests/io/formats/test_to_html.py

pandas/core/frame.py

WillAyd

lgtm - @simonjayhawkins care to take a look as well?

pandas/core/frame.py

pandas/io/formats/format.py

pandas/core/frame.py

simonjayhawkins

@ailurus1991 Thanks for the PR. a few changes for the test. if possible the test should be a similar as possible to test_filepath_or_buffer_arg in test_formats.py.

if you can adapt that test instead, even better!

pandas/core/frame.py

pandas/io/formats/format.py

pandas/tests/io/formats/test_to_html.py

simonjayhawkins · 2019-10-04T22:17:40Z

@WillAyd if encoding is specified and not applicable we should presumably raise? Although I don't think it should be part of this PR. Something to think about so we're consistent across the IO methods.

simonjayhawkins · 2019-10-04T23:44:57Z

@WillAyd if encoding is specified and not applicable we should presumably raise? Although I don't think it should be part of this PR. Something to think about so we're consistent across the IO methods.

#28766 (comment) "We should raise when encoding is specified and it's buf isn't a string path."

simonjayhawkins · 2019-10-04T23:46:36Z

Although I don't think it should be part of this PR.

maybe it should. Since this is effectively an enhancement then it may be worth getting it right off the bat.

…ged, and replace the ensure_clean and DF with pytest built-in tmp_path and float_frame fixture

jreback · 2019-10-08T12:41:55Z

@ailurus1991 looks ok, can you add a whtasnew note in other enhancements section

pandas/tests/io/formats/test_to_html.py

Co-Authored-By: Simon Hawkins <simonjayhawkins@gmail.com>

…/pandas into to_html_encoding_add

simonjayhawkins

@ailurus1991 lgtm @jreback

cailurus · 2019-10-12T02:42:01Z

@ailurus1991 looks ok, can you add a whtasnew note in other enhancements section

@jreback Hi Jeff, I added a simple whatsnew in doc, could you review it? thx

simonjayhawkins · 2019-10-13T11:35:43Z

doc/source/whatsnew/v1.0.0.rst

@@ -312,6 +312,7 @@ I/O
 - Bug in :meth:`DataFrame.to_json` where a datetime column label would not be written out in ISO format with ``orient="table"`` (:issue:`28130`)
 - Bug in :func:`DataFrame.to_parquet` where writing to GCS would fail with `engine='fastparquet'` if the file did not already exist (:issue:`28326`)
 - Bug in :meth:`DataFrame.to_html` where the length of the ``formatters`` argument was not verified (:issue:`28469`)
+- Added ``encoding`` argument to :func:`DataFrame.to_html` for non-ascii text (:issue:`28663`)


see #28692 (comment)

move to other enhancements section

simonjayhawkins

@ailurus1991 Thanks for moving the whatsnew @jreback

jreback · 2019-10-16T12:29:27Z

thanks

cailurus added 3 commits October 1, 2019 03:23

added encoding to to_html

506c222

added encoding to to_html

12fb0c5

added encoding to to_html

842bbc7

josibake reviewed Sep 30, 2019

View reviewed changes

pandas/core/frame.py Outdated Show resolved Hide resolved

fixed docstring with default v

0a3df68

fixed black format issue

70450a2

cailurus mentioned this pull request Sep 30, 2019

to_html()没有encoding参数？造成输出中文显示乱码 #28663

Closed

WillAyd requested changes Oct 1, 2019

View reviewed changes

WillAyd added the IO HTML read_html, to_html, Styler.apply, Styler.applymap label Oct 1, 2019

cailurus added 2 commits October 1, 2019 17:06

added test for pd.to_html encoding arg

0e2bcaf

fixed imports sort issue with isort

0cd9c21

WillAyd requested changes Oct 1, 2019

View reviewed changes

pandas/tests/io/formats/test_to_html.py Outdated Show resolved Hide resolved

pandas/tests/io/formats/test_to_html.py Outdated Show resolved Hide resolved

added issue number as comment and use built-in

0689ad4

WillAyd requested changes Oct 2, 2019

View reviewed changes

pandas/core/frame.py Outdated Show resolved Hide resolved

keep None in highlevel frame api

cb1bd05

WillAyd added this to the 1.0 milestone Oct 2, 2019

WillAyd approved these changes Oct 2, 2019

View reviewed changes

jreback requested changes Oct 3, 2019

View reviewed changes

pandas/core/frame.py Show resolved Hide resolved

pandas/io/formats/format.py Outdated Show resolved Hide resolved

pandas/core/frame.py Outdated Show resolved Hide resolved

simonjayhawkins requested changes Oct 4, 2019

View reviewed changes

cailurus added 3 commits October 8, 2019 13:36

versionadded info added, duplicated docstring removed, arg list reran…

3c792e7

…ged, and replace the ensure_clean and DF with pytest built-in tmp_path and float_frame fixture

fixed tmp_path str type for py35

9f5763d

fixed error typing

d4de348

simonjayhawkins reviewed Oct 8, 2019

View reviewed changes

pandas/tests/io/formats/test_to_html.py Outdated Show resolved Hide resolved

Update pandas/tests/io/formats/test_to_html.py

c8f41c0

Co-Authored-By: Simon Hawkins <simonjayhawkins@gmail.com>

cailurus added 3 commits October 9, 2019 10:39

added whatsnew in v1.0.0 rst

6c89018

Merge branch 'to_html_encoding_add' of https://github.com/ailurus1991…

c9dd1ed

…/pandas into to_html_encoding_add

resolve whatsnew conflicts

338efa3

simonjayhawkins approved these changes Oct 9, 2019

View reviewed changes

simonjayhawkins requested changes Oct 13, 2019

View reviewed changes

cailurus added 2 commits October 13, 2019 19:50

move note to other enhancements section

0cbf56a

Merge remote-tracking branch 'upstream/master' into to_html_encoding_add

ed156f7

simonjayhawkins mentioned this pull request Oct 15, 2019

To string with encoding #28951

Merged

5 tasks

simonjayhawkins approved these changes Oct 15, 2019

View reviewed changes

jreback approved these changes Oct 16, 2019

View reviewed changes

jreback merged commit 79a5f7c into pandas-dev:master Oct 16, 2019

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019

To html encoding add (pandas-dev#28692)

c2383bc

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019

To html encoding add (pandas-dev#28692)

010c8a2

simonjayhawkins mentioned this pull request Dec 28, 2019

Add option encoding to to_html? #30483

Closed

bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020

To html encoding add (pandas-dev#28692)

c3edfd3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

To html encoding add #28692

To html encoding add #28692

cailurus commented Sep 30, 2019 •

edited

Loading

cailurus commented Sep 30, 2019

josibake commented Sep 30, 2019

WillAyd left a comment

WillAyd left a comment

WillAyd left a comment

simonjayhawkins left a comment

simonjayhawkins commented Oct 4, 2019

simonjayhawkins commented Oct 4, 2019

simonjayhawkins commented Oct 4, 2019

jreback commented Oct 8, 2019

simonjayhawkins left a comment

cailurus commented Oct 12, 2019

simonjayhawkins Oct 13, 2019

simonjayhawkins Oct 13, 2019

simonjayhawkins left a comment

jreback commented Oct 16, 2019

To html encoding add #28692

To html encoding add #28692

Conversation

cailurus commented Sep 30, 2019 • edited Loading

cailurus commented Sep 30, 2019

josibake commented Sep 30, 2019

WillAyd left a comment

Choose a reason for hiding this comment

WillAyd left a comment

Choose a reason for hiding this comment

WillAyd left a comment

Choose a reason for hiding this comment

simonjayhawkins left a comment

Choose a reason for hiding this comment

simonjayhawkins commented Oct 4, 2019

simonjayhawkins commented Oct 4, 2019

simonjayhawkins commented Oct 4, 2019

jreback commented Oct 8, 2019

simonjayhawkins left a comment

Choose a reason for hiding this comment

cailurus commented Oct 12, 2019

simonjayhawkins Oct 13, 2019

Choose a reason for hiding this comment

simonjayhawkins Oct 13, 2019

Choose a reason for hiding this comment

simonjayhawkins left a comment

Choose a reason for hiding this comment

jreback commented Oct 16, 2019

cailurus commented Sep 30, 2019 •

edited

Loading