Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: tests/extension/json/test_json.py typefix #28994

Closed
wants to merge 19 commits into from
Closed

CLN: tests/extension/json/test_json.py typefix #28994

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
a19c844
CLN: fix mypy errors in pandas/tests/extension/test_numpy.py #28926
lukasbk Oct 12, 2019
28b7120
Applied suggestions, PR also fixes errors in test_sparse.py
lukasbk Oct 13, 2019
008fe48
Adjusted imports
lukasbk Oct 13, 2019
217adc8
CLN: added type hint for mypy to test_coercion.py
lukasbk Oct 15, 2019
ea903c9
Merge remote-tracking branch 'upstream/master' into test_coercion_typ…
lukasbk Oct 15, 2019
8e8daed
Fixed mypy error in test_json.py
lukasbk Oct 15, 2019
524ce17
reformatting
lukasbk Oct 15, 2019
c642ade
Revert "CLN: added type hint for mypy to test_coercion.py"
lukasbk Oct 16, 2019
b70688f
Merge branch 'master' into test_json_typefix
lukasbk Oct 16, 2019
acf78f9
Matching arguments of assert_..._equal methods
lukasbk Oct 20, 2019
6636d8e
Reformatting
lukasbk Oct 20, 2019
88ef8dd
Merge branch 'master' into test_json_typefix
simonjayhawkins Oct 21, 2019
cfd604c
Removed returns
lukasbk Oct 23, 2019
d1928e9
fix setup.cfg merge conflict
lukasbk Oct 23, 2019
1549313
Merge branch 'test_json_typefix' of github.com:lukasbk/pandas into te…
lukasbk Oct 23, 2019
a7fcf3f
Resolve merge in setup.cfg and reduce base.py
lukasbk Nov 16, 2019
d5856b8
Fix stata files
lukasbk Nov 16, 2019
2da8bad
Change more references to tm
lukasbk Nov 16, 2019
0309fe8
Merge master
lukasbk Dec 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pandas/tests/extension/base/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
from typing import Any

import pandas.util.testing as tm


class BaseExtensionTests:

assert_equal = staticmethod(tm.assert_equal)
assert_series_equal = staticmethod(tm.assert_series_equal)
assert_frame_equal = staticmethod(tm.assert_frame_equal)
assert_series_equal = staticmethod(tm.assert_series_equal) # type: Any
assert_frame_equal = staticmethod(tm.assert_frame_equal) # type: Any
assert_extension_array_equal = staticmethod(tm.assert_extension_array_equal)
3 changes: 2 additions & 1 deletion pandas/tests/indexing/test_coercion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import itertools
from typing import Any, Dict, List

import numpy as np
import pytest
Expand Down Expand Up @@ -928,7 +929,7 @@ class TestReplaceSeriesCoercion(CoercionBase):
klasses = ["series"]
method = "replace"

rep = {}
rep = {} # type: Dict[str, List[Any]]
rep["object"] = ["a", "b"]
rep["int64"] = [4, 5]
rep["float64"] = [1.1, 2.2]
Expand Down
6 changes: 0 additions & 6 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,9 +160,6 @@ ignore_errors=True
[mypy-pandas.tests.extension.json.array]
ignore_errors=True

[mypy-pandas.tests.extension.json.test_json]
ignore_errors=True

[mypy-pandas.tests.frame.test_constructors]
ignore_errors=True

Expand Down Expand Up @@ -196,9 +193,6 @@ ignore_errors=True
[mypy-pandas.tests.indexes.timedeltas.test_timedelta]
ignore_errors=True

[mypy-pandas.tests.indexing.test_coercion]
ignore_errors=True

[mypy-pandas.tests.indexing.test_loc]
ignore_errors=True

Expand Down