Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: tests/extension/json/test_json.py typefix #28994

Closed
wants to merge 19 commits into from
Closed

CLN: tests/extension/json/test_json.py typefix #28994

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
a19c844
CLN: fix mypy errors in pandas/tests/extension/test_numpy.py #28926
lukasbk Oct 12, 2019
28b7120
Applied suggestions, PR also fixes errors in test_sparse.py
lukasbk Oct 13, 2019
008fe48
Adjusted imports
lukasbk Oct 13, 2019
217adc8
CLN: added type hint for mypy to test_coercion.py
lukasbk Oct 15, 2019
ea903c9
Merge remote-tracking branch 'upstream/master' into test_coercion_typ…
lukasbk Oct 15, 2019
8e8daed
Fixed mypy error in test_json.py
lukasbk Oct 15, 2019
524ce17
reformatting
lukasbk Oct 15, 2019
c642ade
Revert "CLN: added type hint for mypy to test_coercion.py"
lukasbk Oct 16, 2019
b70688f
Merge branch 'master' into test_json_typefix
lukasbk Oct 16, 2019
acf78f9
Matching arguments of assert_..._equal methods
lukasbk Oct 20, 2019
6636d8e
Reformatting
lukasbk Oct 20, 2019
88ef8dd
Merge branch 'master' into test_json_typefix
simonjayhawkins Oct 21, 2019
cfd604c
Removed returns
lukasbk Oct 23, 2019
d1928e9
fix setup.cfg merge conflict
lukasbk Oct 23, 2019
1549313
Merge branch 'test_json_typefix' of github.com:lukasbk/pandas into te…
lukasbk Oct 23, 2019
a7fcf3f
Resolve merge in setup.cfg and reduce base.py
lukasbk Nov 16, 2019
d5856b8
Fix stata files
lukasbk Nov 16, 2019
2da8bad
Change more references to tm
lukasbk Nov 16, 2019
0309fe8
Merge master
lukasbk Dec 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions pandas/tests/extension/base/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,18 @@


class BaseExtensionTests:
@staticmethod
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you get rid of these methods altogether and just import / use as function within tests?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, since some tests need to override these

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm OK - so was this change required? Looks like using tm.assert_* in the tests now?

def assert_equal(left, right, **kwargs):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT it's only assert_series_equal and assert_frame_equal that currently need to be overridden in specific extension array tests, so assert_equal and assert_extension_array_equal don't need to be changed at this time.

return tm.assert_equal(left, right, **kwargs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need the return


assert_equal = staticmethod(tm.assert_equal)
assert_series_equal = staticmethod(tm.assert_series_equal)
assert_frame_equal = staticmethod(tm.assert_frame_equal)
assert_extension_array_equal = staticmethod(tm.assert_extension_array_equal)
@staticmethod
def assert_series_equal(left, right, **kwargs):
return tm.assert_series_equal(left, right, **kwargs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same


@staticmethod
def assert_frame_equal(left, right, **kwargs):
return tm.assert_frame_equal(left, right, **kwargs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same


@staticmethod
def assert_extension_array_equal(left, right, **kwargs):
return tm.assert_extension_array_equal(left, right, **kwargs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

6 changes: 3 additions & 3 deletions pandas/tests/extension/json/test_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def assert_series_equal(self, left, right, **kwargs):
)
tm.assert_series_equal(left, right, **kwargs)

def assert_frame_equal(self, left, right, *args, **kwargs):
def assert_frame_equal(self, left, right, **kwargs):
tm.assert_index_equal(
left.columns,
right.columns,
Expand All @@ -108,11 +108,11 @@ def assert_frame_equal(self, left, right, *args, **kwargs):
jsons = (left.dtypes == "json").index

for col in jsons:
self.assert_series_equal(left[col], right[col], *args, **kwargs)
self.assert_series_equal(left[col], right[col], **kwargs)

left = left.drop(columns=jsons)
right = right.drop(columns=jsons)
tm.assert_frame_equal(left, right, *args, **kwargs)
tm.assert_frame_equal(left, right, **kwargs)


class TestDtype(BaseJSON, base.BaseDtypeTests):
Expand Down
3 changes: 0 additions & 3 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,6 @@ ignore_errors=True
[mypy-pandas.tests.extension.json.array]
ignore_errors=True

[mypy-pandas.tests.extension.json.test_json]
ignore_errors=True

[mypy-pandas.tests.indexes.datetimes.test_datetimelike]
ignore_errors=True

Expand Down