CLN: Type error fix in tests\tseries\offsets\test_yqm_offsets.py #28996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error is due to the fact that the builtins.staticmethod type defined in extension.base.base.BaseExtensionTests does not match the function type in extension.json.test_json.BaseJSON. I don't see a possibility for a type hint fix without changing the structure of the code. One way would be to replace the call of staticmethod by function definitions that call the corresponding methods. Here I propose an easier suppression of the error using type: Any. What do you think?
jreback
requested changes
Oct 15, 2019
pandas/tests/extension/base/base.py
Outdated
| import pandas.util.testing as tm | ||
|
|
||
|
|
||
| class BaseExtensionTests: | ||
|
|
||
| assert_equal = staticmethod(tm.assert_equal) | ||
| assert_series_equal = staticmethod(tm.assert_series_equal) | ||
| assert_frame_equal = staticmethod(tm.assert_frame_equal) | ||
| assert_series_equal = staticmethod(tm.assert_series_equal) # type: Any |
There was a problem hiding this comment.
I'm not clear on why these need to be staticmethods at all
38 tasks
|
Alright! Sorry for the mess. Still learning how this git really works ;) |
|
Merging master should fix the CI errors. |
|
Did I do something wrong? |
No, the 3.8 build is just flaky. I restarted it, so hopefully this will be green in a bit. |
WillAyd
approved these changes
Oct 22, 2019
|
Great thanks @lukasbk |
HawkinsBA
pushed a commit
to HawkinsBA/pandas
that referenced
this pull request
Oct 29, 2019
HawkinsBA
pushed a commit
to HawkinsBA/pandas
that referenced
this pull request
Oct 29, 2019
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff