Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Consistent pandas.util.testing imports in pandas/tests/indexing #29291

Conversation

SaturnFromTitan
Copy link
Contributor

Part of #29272

Fyi: All changes are generated from a script posted in the issue.

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@WillAyd
Copy link
Member

WillAyd commented Oct 30, 2019

@SaturnFromTitan can you merge master and push again on this and your other PRs? CI failure unrelated and should have been fixed on master

@WillAyd WillAyd added the Clean label Oct 30, 2019
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm when CI is green

@WillAyd WillAyd added this to the 1.0 milestone Oct 30, 2019
@SaturnFromTitan SaturnFromTitan force-pushed the consistent-imports-util-testing-indexing branch from bc149dd to 53fd649 Compare October 30, 2019 20:40
@SaturnFromTitan
Copy link
Contributor Author

@WillAyd Thanks for letting me know. The PRs are rebased now and all checks passed ✅

@gfyoung gfyoung added the Testing pandas testing functions or related to the test suite label Oct 31, 2019
@gfyoung gfyoung merged commit d70044d into pandas-dev:master Oct 31, 2019
@gfyoung
Copy link
Member

gfyoung commented Oct 31, 2019

Thanks @SaturnFromTitan !

Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants