Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Consistent pandas.util.testing imports in pandas/tests/frame - part 3 #29302

Conversation

SaturnFromTitan
Copy link
Contributor

Part of #29272

Fyi: All changes are generated from a script posted in the issue.

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@gfyoung gfyoung added Clean Testing pandas testing functions or related to the test suite labels Oct 31, 2019
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need tests to pass (failures were unrelated). Nice job!

@jreback jreback added this to the 1.0 milestone Oct 31, 2019
@jreback jreback merged commit ac3d5ad into pandas-dev:master Oct 31, 2019
@jreback
Copy link
Contributor

jreback commented Oct 31, 2019

thanks @SaturnFromTitan

Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants