Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bugs cause replacer's dtype not respected #29317

Merged
merged 1 commit into from
Nov 20, 2019
Merged

fix bugs cause replacer's dtype not respected #29317

merged 1 commit into from
Nov 20, 2019

Conversation

peterpanmj
Copy link
Contributor

@peterpanmj peterpanmj commented Nov 1, 2019 •
edited
Loading

jreback
jreback requested changes Nov 2, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a whatsnew note for 1.0

pandas/core/internals/blocks.py Show resolved Hide resolved
@jreback jreback added Bug Dtype Conversions Unexpected or buggy dtype conversions Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Nov 2, 2019
@peterpanmj
Copy link
Contributor Author

I need some assistance here. #26632

@jreback jreback added this to the 1.0 milestone Nov 13, 2019
@jreback
Copy link
Contributor

jreback commented Nov 13, 2019

I need some assistance here. #26632

?

this PR looks good. if you'd merge master and add a whatsnew note

@peterpanmj
Copy link
Contributor Author

can we just move 2834 here?

I propose an alternative approach in my previous comment. Does it look better ?

WillAyd
WillAyd approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jreback
Copy link
Contributor

jreback commented Nov 19, 2019

lgtm @peterpanmj can you merge master and ping on green.

@peterpanmj peterpanmj force-pushed the replacer_dtype branch 2 times, most recently from a2ca9c4 to f9c8d27 Compare November 20, 2019 01:23
@WillAyd WillAyd merged commit 958756a into pandas-dev:master Nov 20, 2019
@WillAyd
Copy link
Member

WillAyd commented Nov 20, 2019

Thanks @peterpanmj

@peterpanmj peterpanmj deleted the replacer_dtype branch November 20, 2019 05:26
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@peterpanmj @proost
BUG: fix replacer's dtypes not respected for frame replace (pandas-de…
96996b2 
…v#26632) (pandas-dev#29317)
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@peterpanmj @proost
BUG: fix replacer's dtypes not respected for frame replace (pandas-de…
b39f085 
…v#26632) (pandas-dev#29317)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

pd.DataFrame.replace regression causes dtype to remain object
3 participants
@peterpanmj @jreback @WillAyd