DEPR: enforce nested-renaming deprecation #29608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jorisvandenbossche i could use some help figuring out what the intended post-deprecation-enforcement behavior is. From the test failures, I'm guessing some of these cases should not raise? |
|
@jbrockmendel can you give an example of a case you are unsure about? |
jreback
requested changes
Nov 19, 2019
Since the test failures have been fixed, the remaining question is if there are better error messages we should give |
added (but not checked off) to #13777 |
jreback
approved these changes
Nov 19, 2019
|
thanks! |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this deprecation was introduced in #14668 (April 2017), so should be OK to remove by now.
Suggestions for better error messages welcome.
Not passing
_levelaround is pretty nice