Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: bump mypy 0.730 #29653

Merged
merged 2 commits into from
Nov 17, 2019
Merged

CI: bump mypy 0.730 #29653

merged 2 commits into from
Nov 17, 2019

Conversation

simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins added CI Continuous Integration Typing type annotations, mypy/pyright type checking labels Nov 16, 2019
simonjayhawkins
simonjayhawkins commented Nov 16, 2019
View reviewed changes
setup.cfg
[mypy-pandas.tests.indexes.test_base]
ignore_errors=True

[mypy-pandas.tests.indexing.test_loc]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a false positive in 0.720 so can be removed

setup.cfg
@@ -145,10 +145,13 @@ ignore_errors=True
[mypy-pandas.tests.extension.json.test_json]
ignore_errors=True

[mypy-pandas.tests.indexes.datetimes.test_tools]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xref #28932, add #type: ignore as an alternative to ignoring all errors in module

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a 'cleaner' fix in 9849163, that could be simply reverted when --warn-unused-ignores reports issue fixed.

setup.cfg
[mypy-pandas.tests.indexes.test_base]
ignore_errors=True

[mypy-pandas.tests.indexing.test_loc]
[mypy-pandas.tests.scalar.period.test_period]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is now giving error: Module has no attribute "__version__" following #29212

again could add #type: ignore, see cfc2ef7

@simonjayhawkins simonjayhawkins mentioned this pull request Nov 16, 2019
Merged
1 task
WillAyd
WillAyd approved these changes Nov 17, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm whenever travis is green

@simonjayhawkins simonjayhawkins added this to the 1.0 milestone Nov 17, 2019
@jreback jreback merged commit 054936f into pandas-dev:master Nov 17, 2019
@jreback
Copy link
Contributor

jreback commented Nov 17, 2019

thanks @simonjayhawkins

Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
@simonjayhawkins
CI: bump mypy 0.730 (pandas-dev#29653)
0ab1b1a
@simonjayhawkins simonjayhawkins deleted the bump-mypy-0.730 branch November 20, 2019 13:09
@fsouza fsouza mentioned this pull request Nov 21, 2019
Merged
5 tasks
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@simonjayhawkins @proost
CI: bump mypy 0.730 (pandas-dev#29653)
8ea36c2
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@simonjayhawkins @proost
CI: bump mypy 0.730 (pandas-dev#29653)
115f36c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@simonjayhawkins @jreback @WillAyd