Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: remove deprecated keywords in read_excel, to_records #29721

Merged
merged 2 commits into from
Nov 20, 2019

Conversation

jbrockmendel
Copy link
Member

There are a handful of these PRs on the way and they're inevitably going to have whatsnew conflicts. I'm trying to group together related deprecations so as to have a single-digit number of PRs for these.

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks for tackling this

@gfyoung care to take a look?

@WillAyd WillAyd added the Deprecate Functionality to remove in pandas label Nov 20, 2019
@WillAyd WillAyd added this to the 1.0 milestone Nov 20, 2019
@jreback
Copy link
Contributor

jreback commented Nov 20, 2019

lgtm. needs a rebase

@jbrockmendel
Copy link
Member Author

rebased+green

@WillAyd WillAyd merged commit 70b6552 into pandas-dev:master Nov 20, 2019
@WillAyd
Copy link
Member

WillAyd commented Nov 20, 2019

Thanks @jbrockmendel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants