DEPR: remove encoding kwarg from read_stata, DataFrame.to_stata #29722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
commented
Nov 19, 2019
| encoded.to_stata( | ||
| path, write_index=False, version=version, encoding="latin-1" | ||
| ) | ||
| encoded.to_stata(path, write_index=False, version=version) | ||
| reread_encoded = read_stata(path) | ||
| tm.assert_frame_equal(encoded, reread_encoded) |
There was a problem hiding this comment.
not sure if this is still testing anything useful
There was a problem hiding this comment.
Yea can probably just remove this altogether since it seems directed towards encoding
There was a problem hiding this comment.
there's also a the version kwarg. @bashtage is this testing anything meaningful?
There was a problem hiding this comment.
It is testing correctness, but since encoding is a no-op already, I think isn't adding anything. This said, I think it still uses some characters that aren't tested anywhere else.
|
cc @bashtage |
|
Lgtm. |
|
lgtm. rebase and merge. |
|
Thanks @jbrockmendel |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff