DEPR: enforce deprecations in core.internals #29723
Conversation
| @@ -311,7 +311,8 @@ def test_delete(self): | |||
| def test_make_block_same_class(self): | |||
| # issue 19431 | |||
| block = create_block("M8[ns, US/Eastern]", [3]) | |||
| with tm.assert_produces_warning(FutureWarning, check_stacklevel=False): | |||
| with pytest.raises(TypeError, match="unexpected keyword"): | |||
There was a problem hiding this comment.
Should we just remove the dtype argument from this test instead of catching this?
There was a problem hiding this comment.
without the dtpye kwarg its just a smoke test, at which point id rather just remove this test (which id be completely fine with)
There was a problem hiding this comment.
I think OK then. As is this isn't testing anything pandas related just the stdlib
|
lgtm. rebase and merge. |
|
the travis-36-locale build uses fastparquet=0.2.1 which apparently still passes dtype to make_block_same_class. any objection to bumping the required version? |
|
Looks like we last bumped the fastparquet version in #24590 |
|
Yes, I think bumping the minimum fastparquet version is fine. |
agreed here as well. |
|
Happy to bump.
…On Wed, Nov 20, 2019 at 5:32 PM jbrockmendel ***@***.***> wrote:
Looks like we last bumped the fastparquet version in #24590
<#24590>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#29723?email_source=notifications&email_token=AAKAOIT3P4CQOUA7FP5TQIDQUXCIJA5CNFSM4JPKHGJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEWEFYA#issuecomment-556548832>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKAOIXB2FXCSVDBUSTVBBDQUXCIJANCNFSM4JPKHGJQ>
.
|
|
bumped fastparquet to 0.3.0. Wasnt sure what to put in the whatsnew, so I copied the whole minimum-version section from 0.25.0, updated the fastparquet entry, and cut the sentence about py27 having just been dropped. |
|
Looks like 0.3.2 is the version when fastparquet stopped using the deprecated keyword, but that is also the most recent version. are we OK with bumping that far? |
|
looks good, IIRC you have a nother PR where you add the Change column, can update then. |
…ndexing-1row-df * upstream/master: (185 commits) ENH: add BooleanArray extension array (pandas-dev#29555) DOC: Add link to dev calendar and meeting notes (pandas-dev#29737) ENH: Add built-in function for Styler to format the text displayed for missing values (pandas-dev#29118) DEPR: remove statsmodels/seaborn compat shims (pandas-dev#29822) DEPR: remove Index.summary (pandas-dev#29807) DEPR: passing an int to read_excel use_cols (pandas-dev#29795) STY: fstrings in io.pytables (pandas-dev#29758) BUG: Fix melt with mixed int/str columns (pandas-dev#29792) TST: add test for ffill/bfill for non unique multilevel (pandas-dev#29763) Changed description of parse_dates in read_excel(). (pandas-dev#29796) BUG: pivot_table not returning correct type when margin=True and aggfunc='mean' (pandas-dev#28248) REF: Create _lib/window directory (pandas-dev#29817) Fixed small mistake (pandas-dev#29815) minor cleanups (pandas-dev#29798) DEPR: enforce deprecations in core.internals (pandas-dev#29723) add test for unused level raises KeyError (pandas-dev#29760) Add documentation linking to sqlalchemy (pandas-dev#29373) io/parsers: ensure decimal is str on PythonParser (pandas-dev#29743) Reenabled no-unused-function (pandas-dev#29767) CLN:F-string in pandas/_libs/tslibs/*.pyx (pandas-dev#29775) ... # Conflicts: # pandas/tests/frame/indexing/test_indexing.py
Not sure if the whatsnew is needed for this; IIRC it was mainly pyarrow/fastparquet that were using these keywords