DEPR: change DTI.to_series keep_tz default to True #29731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Deprecate
jreback
reviewed
Nov 20, 2019
| @@ -663,14 +663,14 @@ def _get_time_micros(self): | |||
| values = self._data._local_timestamps() | |||
| return fields.get_time_micros(values) | |||
|
|
|||
| def to_series(self, keep_tz=None, index=None, name=None): | |||
| def to_series(self, keep_tz=lib._no_default, index=None, name=None): | |||
There was a problem hiding this comment.
FYI we should standard this argument somewhere and actually have a check that we don't have multiple ways of doing this (a maintenance concern).
1 task
jacobaustin123
pushed a commit
to jacobaustin123/pandas
that referenced
this pull request
Nov 20, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also have a deprecation to remove the keyword altogether, but we can't enforce that until we give people time to stop passing
keep_tz=True