DEPR: remove FrozenNDarray #29840
Merged
DEPR: remove FrozenNDarray #29840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Nov 26, 2019
doc/source/whatsnew/v1.0.0.rst
Outdated
| @@ -433,6 +433,7 @@ or ``matplotlib.Axes.plot``. See :ref:`plotting.formatters` for more. | |||
| - Removed previously deprecated :func:`pandas.tseries.plotting.tsplot` (:issue:`18627`) | |||
| - Removed the previously deprecated ``reduce`` and ``broadcast`` arguments from :meth:`DataFrame.apply` (:issue:`18577`) | |||
| - Removed the previously deprecated ``assert_raises_regex`` function in ``pandas.util.testing`` (:issue:`29174`) | |||
| - Removed the previously deprecated ``FrozenNDArray`` class in ``pandas.core.indexes.frozen`` (:issue:`29335`) | |||
pandas/core/indexes/multi.py
Outdated
| @@ -810,6 +811,13 @@ def set_levels(self, levels, level=None, inplace=False, verify_integrity=True): | |||
| def codes(self): | |||
| return self._codes | |||
|
|
|||
| def _coerce(self, array_like, categories, copy=False): | |||
There was a problem hiding this comment.
can you make this a free function, add types & a doc-string
WillAyd
approved these changes
Nov 27, 2019
jreback
requested changes
Nov 27, 2019
|
rebased+green |
jreback
reviewed
Nov 27, 2019
| @@ -1095,7 +1094,8 @@ def _format_native_types(self, na_rep="nan", **kwargs): | |||
| if mask.any(): | |||
| nan_index = len(level) | |||
| level = np.append(level, na_rep) | |||
| level_codes = level_codes.values() | |||
| assert not level_codes.flags.writeable # i.e. copy is needed | |||
There was a problem hiding this comment.
shoulnt' you be calling _coerce_indexer_frozen here (with copy=True)?
There was a problem hiding this comment.
no, _coerce_indexer_frozen returns an ndarrary that is not writeable, whereas here we have a non-writeable ndarray and need to get a writeable copy
jreback
approved these changes
Nov 29, 2019
|
thanks @jbrockmendel |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reboots #29335.