DEPR: remove get_values, SparseArray.values

[jbrockmendel]

The cleanups in libreduction are made possible by SparseArray.values going away.

[gfyoung]

I would have thought these changes would have been fine...just need to diagnose the CI failures.

[jorisvandenbossche]

Can you add part of the above docstring to this method? (the interesting parts for internal use, eg what it returns)

(and potentially the same comment for some of the other cases below)

[jbrockmendel]

good idea

[WillAyd]

I think there is some JSON code that can get cleaned up as part of this:

pandas/pandas/_libs/src/ujson/python/objToJSON.c

Line 216 in ed20822

// TODO can be removed again once SparseArray.values is removed (GH26421)

[jbrockmendel]

I think there is some JSON code that can get cleaned up as part of this:

Nice. Want me to do that here or save for follow-up?

[WillAyd]

Up to you

[jorisvandenbossche]

I think there is some JSON code that can get cleaned up as part of this:

Nice. Want me to do that here or save for follow-up?

Let's do that here I would say, it's from the same PR that deprecated SparseArray.values: #26421 (you are already removing part of the things of that PR that can be removed)

[jreback]

lgtm. ping when ready (if addressing JSON things)

[jreback]

i would just remove these examples as they are no longer relevant

[jbrockmendel]

removed examples from docstring, left the json since it wasnt obvious what to do in the places where is_sparse_array is currently called

[WillAyd]

lgtm

[jorisvandenbossche]

left the json since it wasnt obvious what to do in the places where is_sparse_array is currently called

From looking at my old PR, I think you can just remove the is_sparse_array where it is used (so change it back to how it was before that PR). SparseArray won't have a values attribute anymore, so that check will work fine now (and not trigger a warning).

[jbrockmendel]

removed is_sparse_array, green

[WillAyd]

Thanks @jbrockmendel