Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: plotting deprecations #30003

Merged
merged 3 commits into from
Dec 5, 2019
Merged

DEPR: plotting deprecations #30003

merged 3 commits into from
Dec 5, 2019

Conversation

jbrockmendel
Copy link
Member

Input/help needed on two outstanding questions:

  1. Do we just remove pandas.tseries.converter after this?
  2. Some of these deprecations are old enough that I couldn't track them down via the blame, so they currently have "(:issue:????)" in the whatsnew.

@jreback jreback added Deprecate Functionality to remove in pandas Visualization plotting labels Dec 4, 2019
@jreback jreback added this to the 1.0 milestone Dec 4, 2019
jreback
jreback approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ex small change (for 2)

  1. pandas.tseries.converter, yes let's remove this entirely

doc/source/whatsnew/v1.0.0.rst Outdated Show resolved Hide resolved
@jbrockmendel
Copy link
Member Author

updated+green

@jreback jreback merged commit 00a2a0e into pandas-dev:master Dec 5, 2019
@jreback
Copy link
Contributor

jreback commented Dec 5, 2019

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the depr-plots branch December 5, 2019 18:06
@jreback jreback mentioned this pull request Dec 5, 2019
Closed
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
DEPR: plotting deprecations (pandas-dev#30003)
c25f641
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
DEPR: plotting deprecations (pandas-dev#30003)
cb86c65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Visualization plotting
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback