Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: make pytables.IndexCol.itemsize a property #30082

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

jbrockmendel
Copy link
Member

Along with #30074 this is a bite-sized-pieces part of a series of PRs that ends with IndexCol attributes being set in the constructor and not mutated elsewhere

@jorisvandenbossche
Copy link
Member

Workflow related question: in your PRs that involve just pytables.py code, can you indicate this in the title? (eg to know this is not about eg Series.itemsize)

@jbrockmendel
Copy link
Member Author

will do

@jbrockmendel jbrockmendel changed the title REF: make itemsize a property REF: make pytables.IndexCol.itemsize a property Dec 5, 2019
@jorisvandenbossche
Copy link
Member

Thanks!

@jreback jreback added the IO HDF5 read_hdf, HDFStore label Dec 5, 2019
@jreback jreback added this to the 1.0 milestone Dec 5, 2019
@jreback jreback merged commit 0adb792 into pandas-dev:master Dec 5, 2019
@jreback
Copy link
Contributor

jreback commented Dec 5, 2019

@jbrockmendel ideally if you can lable with HDF5 and clean/ref as appropriate

@jbrockmendel jbrockmendel deleted the ref-pytables-itemsize branch December 5, 2019 20:10
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO HDF5 read_hdf, HDFStore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants