CI: Checking in f-strings we use {repr(...)} instead of {...!r}

[ShaharNaveh]

• ref Replace "foo!r" to "repr(foo)" syntax #29886
• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

---

Can merge only after merging:

• STY: "{foo!r}" -> "{repr(foo)}" #batch-1 #29948

• STY: "{foo!r}" -> "{repr(foo)}" #batch-2 #29950

• STY: "{foo!r}" -> "{repr(foo)}" #batch-3 #29953

• STY: "{foo!r}" -> "{repr(foo)}" #batch-4 #29959

• STY: "{foo!r}" -> "{repr(foo)}" #batch-5 #29963

[WillAyd]

@MomIsBestFriend I think all precursors are done (?) can you merge master?

[ShaharNaveh]

@WillAyd sorry for the delay, was on vacation.

Do you have an idea on how to exclude patterns like %%r?

[jbrockmendel]

Do you have an idea on how to exclude patterns like %%r?

You want to grep for "%r" but exclude "%%r" right?

With regular grep you could do grep -R --include=*.{py,pyx} '%r' pandas | grep -v '%%r'. I'm not sure what it will take to make this work with the invgrep in the code checks

[ShaharNaveh]

Do you have an idea on how to exclude patterns like %%r?

You want to grep for "%r" but exclude "%%r" right?

With regular grep you could do grep -R --include=*.{py,pyx} '%r' pandas | grep -v '%%r'. I'm not sure what it will take to make this work with the invgrep in the code checks

That's an interesting way of doing it, the problem is that the return status is messing my head. because the invgrep is giving the opposite return status of grep. I just changed the matching pattern to make my life easier.

Hope my way of thinking is good.

[jbrockmendel]

@MomIsBestFriend pls rebase. did you figure out the grep issue?

[ShaharNaveh]

did you figure out the grep issue?

Yes, I am greping for <Space>%r because it's more common, all the rest are edge cases, so it's not really worth writing test cases for them.

[datapythonista]

Thanks for adding those @MomIsBestFriend

The second rule looks ok, but I'm unsure about the first one.

[ShaharNaveh]

Sorry for the short mess, messed something with the HEAD and the upstream/maser pointers.

It's all good now, correct?

[datapythonista]

lgtm, thanks @MomIsBestFriend

[jreback]

thanks @MomIsBestFriend