Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: collect pytables DataCol.set_data calls in one place #30101

Merged
merged 5 commits into from
Dec 6, 2019
Merged

REF: collect pytables DataCol.set_data calls in one place #30101

merged 5 commits into from
Dec 6, 2019

Conversation

jbrockmendel
Copy link
Member

This is part 1 of 2 of the payoff promised from #30074.

@jbrockmendel jbrockmendel mentioned this pull request Dec 6, 2019
Merged
@jbrockmendel jbrockmendel added IO HDF5 read_hdf, HDFStore Refactor Internal refactoring of code labels Dec 6, 2019
@jbrockmendel
Copy link
Member Author

Rebased following #30102, we get to rip out a bunch of set_atom_foo methods. After this and #30100, we'll finally be able to pass everything to the relevant constructors here.

@jreback jreback added this to the 1.0 milestone Dec 6, 2019
@jreback jreback merged commit 5722f72 into pandas-dev:master Dec 6, 2019
@jreback
Copy link
Contributor

jreback commented Dec 6, 2019

thanks

@jbrockmendel jbrockmendel deleted the ref-pytables-set_data branch December 6, 2019 15:26
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
REF: collect pytables DataCol.set_data calls in one place (pandas-dev…
b275e0d 
…#30101)
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
REF: collect pytables DataCol.set_data calls in one place (pandas-dev…
50e35d3 
…#30101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
IO HDF5 read_hdf, HDFStore Refactor Internal refactoring of code
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback