DEPR: msgpack #30112
DEPR: msgpack #30112
Conversation
|
could use some help on the whatsnew 0.13.0 file |
|
I would think OK to just remove that section of the whatsnew |
can you leave it as a code-block? |
leaving it as-is I get errors in the docbuild bc the msgpack funcs arent defined. |
| .. _io.msgpack: | ||
|
|
||
| msgpack | ||
| ------- |
There was a problem hiding this comment.
Given that this is deprecated/removed on a very short time frame, I think it might be good to keep this title a bit longer with a small note that it was deprecated/removed and how to replace it.
There was a problem hiding this comment.
why? the whole point is to clean things for 1.0
There was a problem hiding this comment.
To provide documentation about this removal, and how to replace it.
For example, there have been issues opened with questions about this which lead to added examples in the docstrings, but this has never been published yet in actual documentation.
There was a problem hiding this comment.
restored this section. LMK if you have suggestions for additional notes to put in here.
any thoughts on the LICENSE files mentioned in the OP?
There was a problem hiding this comment.
I wouldn't restore the full section, but rather only keep a short explanation that it was deprecated/removed, and how to replace it (see the docstrings for some content for that)
I suppose so yes? If we don't keep any code of it, we can remove the licenses as well? |
yes for sure |
|
pls rebase |
| :okwarning: | ||
|
|
||
| pd.read_msgpack(df.to_msgpack() + s.to_msgpack()) | ||
| pandas support for ``msgpack`` has been removed in version 1.0.0. It is recommended to use pyarrow for on-the-wire transmission of pandas objects. |
There was a problem hiding this comment.
we currently have a small code snippet in the doc-string of how to use pyarrow, can you copy it here as a code-block
doc/source/user_guide/io.rst
Outdated
| pd.read_msgpack(df.to_msgpack() + s.to_msgpack()) | ||
| For documentation on pyarrow, see `here<https://arrow.apache.org/docs/python/index.html>`__. |
There was a problem hiding this comment.
i think the docbuild is complaining about this. help @jorisvandenbossche ?
There was a problem hiding this comment.
| For documentation on pyarrow, see `here<https://arrow.apache.org/docs/python/index.html>`__. | |
| For documentation on pyarrow, see `here <https://arrow.apache.org/docs/python/index.html>`__. |
There was a problem hiding this comment.
I think the double underscore is the issue
There was a problem hiding this comment.
The double underscore is correct, but I suspect the space that you corrected is the problem though
There was a problem hiding this comment.
looks like that fixed it, thanks
|
lgtm. @jorisvandenbossche |
|
Thanks @jbrockmendel ! |
there are two msgpack files in LICENSES, should those go?