-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add ignore_index for df.sort_values and series.sort_values #30402
Merged
Merged
Changes from 9 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
7e461a1
remove \n from docstring
charlesdong1991 1314059
fix conflicts
charlesdong1991 8bcb313
Merge remote-tracking branch 'upstream/master'
charlesdong1991 1f9a4ce
Merge remote-tracking branch 'upstream/master' into fix_issue_30114
charlesdong1991 5f924c3
Merge remote-tracking branch 'upstream/master' into fix_issue_30114
charlesdong1991 d0a134f
Add ignore index for sort values
charlesdong1991 6d52765
black reformat
charlesdong1991 a31797d
add tests
charlesdong1991 b80f380
remove type hint to see if test passes
charlesdong1991 b997d3f
code change based on WA review
charlesdong1991 12d1260
restore reformat change on other parts
charlesdong1991 4ff2493
revert change
charlesdong1991 e9d63f4
change bool
charlesdong1991 70ffec7
remove annotation
charlesdong1991 b4245d7
remove for series
charlesdong1991 f9e7ec2
add ignore_index for series
charlesdong1991 d95a89f
keep consistency
charlesdong1991 f241e67
revert change
charlesdong1991 7f9846a
resolve conflict
charlesdong1991 bbb4754
restore change
charlesdong1991 3c37eb9
code change based on WA and JR reviews
charlesdong1991 4ce9f43
better english
charlesdong1991 0f89aa2
skip annotation
charlesdong1991 d02b651
code change on JR review
charlesdong1991 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -474,6 +474,7 @@ Other API changes | |
Supplying anything else than ``how`` to ``**kwargs`` raised a ``TypeError`` previously (:issue:`29388`) | ||
- When testing pandas, the new minimum required version of pytest is 5.0.1 (:issue:`29664`) | ||
- :meth:`Series.str.__iter__` was deprecated and will be removed in future releases (:issue:`28277`). | ||
- ``ignore_index`` is added in :meth:`DataFrame.sort_values` to be able to get reset index after sorting (:issue:`30114`) | ||
|
||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. move this to other enhancements |
||
.. _whatsnew_1000.api.documentation: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! will change!