TST: Add tests for fixed issues #30444
Conversation
|
Hello @mroeschke! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-12-24 22:18:54 UTC |
mroeschke
added
the
Testing
|
looks like a int32 vs int64 issue? |
|
@jbrockmendel looks like that was the issue. All green |
pandas/tests/indexing/test_loc.py
Outdated
| # GH 6485 | ||
| result = DataFrame({"a": range(10)}, dtype="i4") | ||
| result.loc[10] = 99 | ||
| expected = DataFrame({"a": list(range(10)) + [99]}) |
There was a problem hiding this comment.
can you specify the expected dtype here? im actually not clear on why this is "fixed". casting to int64 is better than casting to float64 like it did in the OP in #6485, but dont we want the dtype to stay int32?
Also, there is mention in that issue of an empty case that is still broken. should that issue stay open or new issue for the still-broken case?
There was a problem hiding this comment.
Good point. Ideally we should maintain int32 here. I guess that issue is not totally solved and it leave it open for both cases
|
the other 3 LGTM |
|
thanks @mroeschke |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff