Disallow bare pytest.raises #31029
Closed
Disallow bare pytest.raises #31029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/tests/io/test_html.py
Outdated
| @@ -276,14 +276,14 @@ def test_file_like(self): | |||
|
|
|||
| @tm.network | |||
| def test_bad_url_protocol(self): | |||
| with pytest.raises(URLError): | |||
| with pytest.raises(URLError, match=msg): | |||
gfyoung
added
Code Style
|
Thanks @DylanBrdt for the PR. In future you should create a new branch on your local fork when making a PR request. see https://dev.pandas.io/docs/development/contributing.html#creating-a-branch |
| @@ -1374,7 +1374,7 @@ def test_unsupported_datetype(self): | |||
| "dates": dates, | |||
| } | |||
| ) | |||
| with pytest.raises(NotImplementedError): | |||
| with pytest.raises(NotImplementedError, match=msg): | |||
There was a problem hiding this comment.
Suggested change
| with pytest.raises(NotImplementedError, match=msg): | |
| with pytest.raises( | |
| NotImplementedError, | |
| match=re.escape("Data type datetime64[ns, Asia/Hong_Kong] not supported."), | |
| ): |
also re needs to be imported.
|
Hi @DylanBrdt - are you still interested in working on this? |
|
@MarcoGorelli I appreciate your consideration of asking me. Unfortunately, I am still learning OSS and want to learn the basics of git before I attempt any more issues. |
|
OK. closing for now. |
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff#30999