-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Remove bare pytest.raises #31079
Conversation
@@ -281,6 +282,8 @@ def test_add(self): | |||
|
|||
def test_sub_fail(self): | |||
index = tm.makeStringIndex(100) | |||
|
|||
# TODO: Make raised error message more informative and test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for the TODO here instead of adding the message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WillAyd . I was not sure what a good error message for this function would be. Does the error message added in my previous commit work?
Could someone give me some direction on resolving the failed integration tests? I do not understand how changing a string to an f-string in my latest commit would cause the error: |
I think GitHub CI was temporarily down; just restarted let's see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
thanks @gdex1 |
@MomIsBestFriend . I've finished adding match arguments for pytest.raises calls in these files. Should I add an entry to the "whatsnew" file? Or will there be one added later related to the original issue you opened? Thanks. |
@gdex1 First, thank you for contributing:) And the "what's new" is a file that's displayed to users who wants to learn what's changed. the tests are for us to test the code, the external users do not use these tests and they also don't see these tests, so no you should not create a what's new file. And there will be no new entry for the related issue :) Side note: :) |
References #30999
Adds match argument to pytest.raises found in the following files. #30999 (comment)
ToDo: