Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PR: BUG: Array.__setitem__ failing with nullable boolean mask (#31484) #31562

Merged
merged 1 commit into from
Feb 2, 2020
Merged

Backport PR: BUG: Array.__setitem__ failing with nullable boolean mask (#31484) #31562

merged 1 commit into from
Feb 2, 2020

Conversation

charlesdong1991
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@charlesdong1991 charlesdong1991 mentioned this pull request Feb 2, 2020
Closed
@WillAyd
Copy link
Member

WillAyd commented Feb 2, 2020

looks good

@charlesdong1991
Copy link
Member Author

thanks for the tip! appreciate a lot! @WillAyd

@charlesdong1991
Copy link
Member Author

emm, error does not seem to be related to this pr, #30588

@AlexKirko AlexKirko mentioned this pull request Feb 2, 2020
Closed
@charlesdong1991 charlesdong1991 mentioned this pull request Feb 2, 2020
Merged
5 tasks
@jreback jreback added this to the 1.0.1 milestone Feb 2, 2020
@jreback jreback added Indexing Related to indexing on series/frames, not to indexes themselves Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Feb 2, 2020
@jreback jreback merged commit 4082c46 into pandas-dev:1.0.x Feb 2, 2020
@jreback
Copy link
Contributor

jreback commented Feb 2, 2020

thanks @charlesdong1991

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@charlesdong1991 @WillAyd @jreback