Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type errors in pandas/tests/extension/json/array.py #31718

Conversation

SaturnFromTitan
Copy link
Contributor

Part of #28926

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@jbrockmendel
Copy link
Member

nitpick: when naming these PRs, "fix type errors" makes me think there is a TypeError being raised somewhere. something involving "annotations" or "mypy" might be more clear

@jbrockmendel
Copy link
Member

restarted the azure build

@WillAyd WillAyd added the Typing type annotations, mypy/pyright type checking label Feb 5, 2020
@WillAyd WillAyd added this to the 1.1 milestone Feb 5, 2020
@WillAyd WillAyd merged commit daf5bb4 into pandas-dev:master Feb 5, 2020
@WillAyd
Copy link
Member

WillAyd commented Feb 5, 2020

Thanks @SaturnFromTitan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants