fixed mypy errors in mypy-pandas.tests.extension.decimal.test_decimal #31730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaturnFromTitan
force-pushed
the
28926-fix-mypy-errors-for-pandas-tests-extension-decimal-test_decimal
branch
from
eff526d to
8f13e39
Compare
jbrockmendel
reviewed
Feb 6, 2020
| @@ -103,7 +105,7 @@ def assert_frame_equal(self, left, right, *args, **kwargs): | |||
| decimals = (left.dtypes == "decimal").index | |||
|
|
|||
| for col in decimals: | |||
| self.assert_series_equal(left[col], right[col], *args, **kwargs) | |||
| BaseDecimal.assert_series_equal(left[col], right[col], *args, **kwargs) | |||
There was a problem hiding this comment.
this looks like it should be a classmethod
There was a problem hiding this comment.
What would be the advantage of using classmethod over staticmethod? I typically only use classmethod if I need multiple ways of instantiation
There was a problem hiding this comment.
having BaseDecimal hard-coded here looks like a kludge, I'm speculating that what you want here is cls.assert_series_equal, kind of halfway inbetween the regular method it is now and the staticmethod in the PR
|
lgtm outside of @jbrockmendel comments |
jreback
added
ExtensionArray
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #28926
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff