Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed mypy errors in pandas/tests/extension/json/test_json.py #31836

Merged
merged 1 commit into from
Feb 9, 2020
Merged

Fixed mypy errors in pandas/tests/extension/json/test_json.py #31836

merged 1 commit into from
Feb 9, 2020

Conversation

SaturnFromTitan
Copy link
Contributor

Part of #28926

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

simonjayhawkins
simonjayhawkins approved these changes Feb 9, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SaturnFromTitan lgtm @WillAyd

@simonjayhawkins simonjayhawkins added Testing pandas testing functions or related to the test suite Typing type annotations, mypy/pyright type checking labels Feb 9, 2020
@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Feb 9, 2020
@simonjayhawkins simonjayhawkins mentioned this pull request Feb 9, 2020
Closed
38 tasks
@WillAyd WillAyd merged commit d2a14ac into pandas-dev:master Feb 9, 2020
@WillAyd
Copy link
Member

WillAyd commented Feb 9, 2020

Thanks @SaturnFromTitan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@SaturnFromTitan @WillAyd @simonjayhawkins