-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Reorganize Getting Started documentation pages #32389
Conversation
@@ -23,7 +21,7 @@ Before you can use pandas, you’ll need to get it installed. | |||
<div class="card-body"> | |||
<p class="card-text"> | |||
|
|||
Pandas is part of the `Anaconda <http://docs.continuum.io/anaconda/>`__ distribution and can be | |||
pandas is part of the `Anaconda <http://docs.continuum.io/anaconda/>`__ distribution and can be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to move *pandas*
to pandas
#32316
My sphinx-foo is a bit poor. I see I'm getting these doc build warnings
And we have a note in the docs
But still unsure what I need to change in |
@mroeschke for the warnings, I think you need to add a toctree to |
Or alternatively put However, I think we want to include it in a toctree for better visibility? |
Yeah, I think including it is better. I think putting it in an |
intro_tutorials/index | ||
basics | ||
dsintro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should just remove basics and dsintro, but keep them somewhere in the docs. I personally would move them to the user guide, but so that means they need to be added to the toctree there if we want to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added them as links in the user guide but hadn't added it to the toctree there yet.
https://github.com/pandas-dev/pandas/pull/32389/files#diff-e81313c8de3a67eb46e6744b7c895af2R15
doc/source/getting_started/index.rst
Outdated
Tutorials | ||
--------- | ||
|
||
For a quick introduction to pandas, see :ref:`10 Minutes to pandas<10min>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally find "quick overview of pandas functionality" a better description, as I don't it a very "introductory" in the sense of that it doesn't explain much, but mainly shows briefly most areas of pandas functionality.
(but as I said on the issue, I am not fully sure what best to do with or how to frame this 10min page)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will also need redirects for the moved pages
I am not sure about moving 10min to the user guide. In any case, based on its name I would say it belongs in the getting started section. cc @datapythonista are you OK with moving dsintro.rst and basics.rst back to the user guide? (since you put them in the getting started section when the split was done) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open to move 10min... to the user guide.
The division I made was thinking on what documentation was for people new to pandas, and what for existing users. And those felt more like they were for people getting started.
But I think ideally the getting started documentation should be something to be read sequentially by new users, and I guess moving those to the user guide is moving in that direction.
Happy with both.
doc/source/getting_started/index.rst
Outdated
@@ -3,14 +3,12 @@ | |||
.. _getting_started: | |||
|
|||
=============== | |||
Getting started | |||
Getting Started |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are moving in the opposite direction, see #31114
doc/source/getting_started/index.rst
Outdated
also provides the <code>data set</code> corresponding to the pandas <code>data.frame</code>. | ||
Also vectorized operations, filtering, string processing operations,... from SAS have similar | ||
also provides the <code>data set</code> corresponding to the pandas <code>dataframe</code>. | ||
Also vectorized operations, filtering, string processing operations, and more from SAS have similar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll know better, but may be this is clearer?
Also vectorized operations, filtering, string processing operations, and more from SAS have similar | |
Also SAS vectorized operations, filtering, string processing operations, and more have similar |
@@ -7,13 +7,10 @@ release,whatsnew/index | |||
|
|||
# getting started | |||
install,getting_started/install | |||
10min,getting_started/10min |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how to specify the redirects if they switch sections @jorisvandenbossche
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be 10min,user_guide/10min
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect that worked.
Planning on merging tomorrow if there are no further comments. |
* DOC: Reorganize Getting Started documentation pages * Move some docs to user_guide, and adjust phrasing * Modify redirects, fix phrasing in getting_started * modify redirects Co-authored-by: Matt Roeschke <mroeschke@housecanary.com>
Issue Related:
getting_started/index.html
removes10 minutes to pandas
,Essential basic functionality
andIntro to data structures
from the toctree and moves them as links inuser_guide/index.html
getting_started/tutorials.html
now only references community tutorialsTutorial
section ofgetting_started/index.html
Misc:
Pandas
topandas