Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Reorganize Getting Started documentation pages #32389

Merged
merged 5 commits into from
Mar 11, 2020

Conversation

mroeschke
Copy link
Member

Issue Related:

  • getting_started/index.html removes 10 minutes to pandas, Essential basic functionality and Intro to data structures from the toctree and moves them as links in user_guide/index.html
  • getting_started/tutorials.html now only references community tutorials
  • the pandas cheatsheet is now referenced at the bottom Tutorial section of getting_started/index.html

Misc:

  • Lowercases Pandas to pandas
  • Some rephrasing

@mroeschke mroeschke added the Docs label Mar 2, 2020
@@ -23,7 +21,7 @@ Before you can use pandas, you’ll need to get it installed.
<div class="card-body">
<p class="card-text">

Pandas is part of the `Anaconda <http://docs.continuum.io/anaconda/>`__ distribution and can be
pandas is part of the `Anaconda <http://docs.continuum.io/anaconda/>`__ distribution and can be
Copy link
Member

@MarcoGorelli MarcoGorelli Mar 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in #32388 , pandas is being written

*pandas*

, should that be done here as well for consistency?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to move *pandas* to pandas #32316

@mroeschke
Copy link
Member Author

My sphinx-foo is a bit poor.

I see I'm getting these doc build warnings

2020-03-02T07:41:43.8295810Z /home/runner/work/pandas/pandas/doc/source/getting_started/10min.rst: WARNING: document isn't included in any toctree
2020-03-02T07:41:43.8296699Z /home/runner/work/pandas/pandas/doc/source/getting_started/basics.rst: WARNING: document isn't included in any toctree
2020-03-02T07:41:43.8297521Z /home/runner/work/pandas/pandas/doc/source/getting_started/dsintro.rst: WARNING: document isn't included in any toctree

And we have a note in the docs

.. If you update this toctree, also update the manual toctree in the
   main index.rst.template

But still unsure what I need to change in index.rst.template

@mroeschke
Copy link
Member Author

cc @jorisvandenbossche

@TomAugspurger
Copy link
Contributor

@mroeschke for the warnings, I think you need to add a toctree to tutorials.rst with those (10min, etc.) documents included. Otherwise they won't be included in the output.

@jorisvandenbossche
Copy link
Member

Or alternatively put :orphan: on the top of the rst page that is not included in any toctree but we still want to include in the output, which will silence the warnings as well.

However, I think we want to include it in a toctree for better visibility?

@TomAugspurger
Copy link
Contributor

Yeah, I think including it is better. I think putting it in an :orphan: page also kinda breaks "next" and "previous" links.

intro_tutorials/index
basics
dsintro
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should just remove basics and dsintro, but keep them somewhere in the docs. I personally would move them to the user guide, but so that means they need to be added to the toctree there if we want to do that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added them as links in the user guide but hadn't added it to the toctree there yet.

https://github.com/pandas-dev/pandas/pull/32389/files#diff-e81313c8de3a67eb46e6744b7c895af2R15

Tutorials
---------

For a quick introduction to pandas, see :ref:`10 Minutes to pandas<10min>`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally find "quick overview of pandas functionality" a better description, as I don't it a very "introductory" in the sense of that it doesn't explain much, but mainly shows briefly most areas of pandas functionality.

(but as I said on the issue, I am not fully sure what best to do with or how to frame this 10min page)

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also need redirects for the moved pages

@jorisvandenbossche
Copy link
Member

I am not sure about moving 10min to the user guide. In any case, based on its name I would say it belongs in the getting started section.

cc @datapythonista are you OK with moving dsintro.rst and basics.rst back to the user guide? (since you put them in the getting started section when the split was done)

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to move 10min... to the user guide.

The division I made was thinking on what documentation was for people new to pandas, and what for existing users. And those felt more like they were for people getting started.

But I think ideally the getting started documentation should be something to be read sequentially by new users, and I guess moving those to the user guide is moving in that direction.

Happy with both.

@@ -3,14 +3,12 @@
.. _getting_started:

===============
Getting started
Getting Started
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are moving in the opposite direction, see #31114

also provides the <code>data set</code> corresponding to the pandas <code>data.frame</code>.
Also vectorized operations, filtering, string processing operations,... from SAS have similar
also provides the <code>data set</code> corresponding to the pandas <code>dataframe</code>.
Also vectorized operations, filtering, string processing operations, and more from SAS have similar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll know better, but may be this is clearer?

Suggested change
Also vectorized operations, filtering, string processing operations, and more from SAS have similar
Also SAS vectorized operations, filtering, string processing operations, and more have similar

@@ -7,13 +7,10 @@ release,whatsnew/index

# getting started
install,getting_started/install
10min,getting_started/10min
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to specify the redirects if they switch sections @jorisvandenbossche

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be 10min,user_guide/10min ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect that worked.

@mroeschke
Copy link
Member Author

Planning on merging tomorrow if there are no further comments.

@mroeschke mroeschke merged commit 1f2385e into pandas-dev:master Mar 11, 2020
@mroeschke mroeschke deleted the reorg_getting_started branch March 11, 2020 22:15
@mroeschke mroeschke added this to the 1.1 milestone Mar 11, 2020
SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
* DOC: Reorganize Getting Started documentation pages

* Move some docs to user_guide, and adjust phrasing

* Modify redirects, fix phrasing in getting_started

* modify redirects

Co-authored-by: Matt Roeschke <mroeschke@housecanary.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Consolidate pages under /docs/getting_started
6 participants