Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed validate_string_concatenation.py to validate_unwanted_patterns.py #32926

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Renamed validate_string_concatenation.py to validate_unwanted_patterns.py #32926

merged 1 commit into from
Mar 23, 2020

Conversation

ShaharNaveh
Copy link
Member

Follow up for #30755

@simonjayhawkins simonjayhawkins added Code Style Code style, linting, code_checks CI Continuous Integration labels Mar 23, 2020
@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Mar 23, 2020
simonjayhawkins
simonjayhawkins approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MomIsBestFriend lgtm pending green

datapythonista
datapythonista approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @MomIsBestFriend

@datapythonista datapythonista merged commit bbfecaf into pandas-dev:master Mar 23, 2020
@ShaharNaveh ShaharNaveh deleted the STY-rename-file branch March 23, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

@datapythonista datapythonista datapythonista approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ShaharNaveh @datapythonista @simonjayhawkins