ENH: add ignore_index option in DataFrame.explode

[erfannariman]

• closes ENH: add ignore_index argument to DataFrame.explode / Series.explode #34932
• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[erfannariman]

Note that I'm trying to push a commit for the doc strings, but I can't get passed the pre-commit because of error: unused 'type: ignore' comment.

[TomAugspurger]

but I can't get passed the pre-commit because of error: unused 'type: ignore' comment.

You can use git commit --no-verify. Sometimes mypy struggles with partial diffs.

[TomAugspurger]

We'll need a release note in 1.1.0.rst and tests.

You should also add the same keyword to Series.explode.

[erfannariman]

@TomAugspurger added the changes you requested for DataFrame.explod and Series.explode, will look into release note in 1.1.0.rst and tests. Not really familiar with this so will try myself first,but if I need help can I ask you some questions?

[TomAugspurger]

Yep. There should be examples you can base yours off of. For the release note, this can go in the "Other enhancements" section.

…

On Mon, Jun 22, 2020 at 8:51 AM Erfan Nariman ***@***.***> wrote: @TomAugspurger <https://github.com/TomAugspurger> added the changes you requested for DataFrame.explod and Series.explode, will look into release note in 1.1.0.rst and tests. Not really familiar with this so will try myself first,but if I need help can I ask you some questions? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#34933 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKAOIX5QIOYWE3KHDUEXETRX5OPTANCNFSM4OEPYUXA> .

[erfannariman]

@TomAugspurger I think I added all the requests you had, will check the merge conflict, not sure how this could happen.

[erfannariman]

The new test fails because of differences in types:

def test_ignore_index():
        # GH 34932
        s = pd.Series([[1, 2], [3, 4]])
        result = s.explode(ignore_index=True)
        expected = pd.Series([1, 2, 3, 4], index=[0, 1, 2, 3])
>       tm.assert_series_equal(result, expected)
E       AssertionError: Attributes of Series are different
E       
E       Attribute "dtype" are different
E       [left]:  object
E       [right]: int64

[erfannariman]

@TomAugspurger @jorisvandenbossche I think I made all the changes you guys requested, if there's anything more I can do, please let me know.

[jreback]

looks good a couple of comments, ping on green.

[jorisvandenbossche]

@erfannariman can you push the changes you made?

[erfannariman]

Not sure why this change should trigger tests/tseries/offsets/test_offsets_properties.test_on_offset_implementations to fail.

[jreback]

if you can make that change and merge master can get this in

[erfannariman]

if you can make that change and merge master can get this in

I think I made all the changes you requested, is there anything else you would like me to do?

[jreback]

looks good, pls revert the part of the whatsnew that was changed; only your change should be in the diff. ping on green.

[erfannariman]

The check that fails seems to happen because of merging master, libreduction is now unused in core/apply.py.

[jreback]

thanks @erfannariman very nice

[erfannariman]

thanks for reviewing and helping @jreback