BUG: Ensure rolling groupby doesn't segfault with center=True #35562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doc/source/whatsnew/v1.1.1.rst
Outdated
| @@ -16,7 +16,7 @@ Fixed regressions | |||
| ~~~~~~~~~~~~~~~~~ | |||
|
|
|||
| - Fixed regression where :func:`read_csv` would raise a ``ValueError`` when ``pandas.options.mode.use_inf_as_na`` was set to ``True`` (:issue:`35493`). | |||
| - | |||
| - Fixed regression in :class:`pandas.core.groupby.RollingGroupby` where a segfault would occur with ``center=True`` and an odd number of values (:issue:`35552`) | |||
There was a problem hiding this comment.
pandas.core.groupby.RollingGroupby doesn't exist, so this link won't work (it's in the window module). But, we actually don't have this in the API docs it seems, so won't work anyway. I would just do something like .groupby(..).rolling(..) to indicate which operation is affected.
jreback
added
the
Regression
|
can you merge master, looks good |
|
thanks @mroeschke |
|
@meeseeksdev backport to 1.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 7, 2020
…fault with center=True
jreback
pushed a commit
that referenced
this pull request
Aug 7, 2020
… center=True (#35610) Co-authored-by: Matthew Roeschke <emailformattr@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff