Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: RollingGroupby with closed and column selection no longer raises ValueError #35639

Merged
merged 2 commits into from
Aug 10, 2020

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke added this to the 1.1.1 milestone Aug 9, 2020
@mroeschke mroeschke added Bug Window rolling, ewma, expanding labels Aug 9, 2020
@jreback jreback merged commit 6875a05 into pandas-dev:master Aug 10, 2020
@jreback
Copy link
Contributor

jreback commented Aug 10, 2020

thanks @mroeschke

@jreback
Copy link
Contributor

jreback commented Aug 10, 2020

@meeseeksdev backport 1.1.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 10, 2020
simonjayhawkins pushed a commit that referenced this pull request Aug 10, 2020
…ion no longer raises ValueError (#35651)

Co-authored-by: Matthew Roeschke <emailformattr@gmail.com>
@mroeschke mroeschke deleted the bug/groupby_rolling_closed branch August 10, 2020 15:26
@simonjayhawkins simonjayhawkins mentioned this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Window rolling, ewma, expanding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Closed parameter in rolling function producing ValueError
2 participants