Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF/BUG/TYP: read_csv shouldn't close user-provided file handles #36997

Merged
merged 10 commits into from
Nov 4, 2020
Merged

REF/BUG/TYP: read_csv shouldn't close user-provided file handles #36997

merged 10 commits into from
Nov 4, 2020

Commits on Nov 3, 2020

  1. BUG/REF: read_csv shouldn't close user-provided file handles

    @twoertwein
    twoertwein committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    618b6eb View commit details
    Browse the repository at this point in the history

  2. get_handle: typing, returns is_wrapped, use dataclass, and make sure … 

    …that all created handlers are returned
    @twoertwein
    twoertwein committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    4f26aea View commit details
    Browse the repository at this point in the history

  3. remove unused imports

    @twoertwein
    twoertwein committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    443a91e View commit details
    Browse the repository at this point in the history

  4. added IOHandleArgs.close

    @twoertwein
    twoertwein committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    6a10513 View commit details
    Browse the repository at this point in the history

  5. added IOArgs.close

    @twoertwein
    twoertwein committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    60fc0a8 View commit details
    Browse the repository at this point in the history

  6. mostly comments

    @twoertwein
    twoertwein committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    e65c4d9 View commit details
    Browse the repository at this point in the history

  7. move memory_map from TextReader to CParserWrapper

    @twoertwein
    twoertwein committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    1378221 View commit details
    Browse the repository at this point in the history

  8. moved IOArgs and IOHandles

    @twoertwein
    twoertwein committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    74c6872 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2020

  1. more comments

    @twoertwein
    twoertwein committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    4dc58a6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into read_csv

    @jreback
    jreback authored Nov 4, 2020
    Configuration menu
    Copy the full SHA
    8ce25d1 View commit details
    Browse the repository at this point in the history