Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add MultiIndex.dtypes #37073

Merged
merged 15 commits into from
Dec 11, 2020
Merged

ENH: Add MultiIndex.dtypes #37073

merged 15 commits into from
Dec 11, 2020

Conversation

skvrahul
Copy link
Contributor

  • closes ENH: MultiIndex.dtypes #37062
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Adds the .dtypes property to MultiIndex using the suggested implementation

jreback
jreback requested changes Oct 12, 2020
View reviewed changes
doc/source/whatsnew/v1.2.0.rst Outdated Show resolved Hide resolved
pandas/tests/indexes/multi/test_get_set.py Outdated Show resolved Hide resolved
@skvrahul skvrahul requested a review from jreback October 14, 2020 05:28
@skvrahul
Copy link
Contributor Author

@jreback Made the requested changes. Could you take a look?

@jreback
Copy link
Contributor

jreback commented Nov 4, 2020

can you merge master

@skvrahul
Copy link
Contributor Author

skvrahul commented Nov 5, 2020

can you merge master

Done.

arw2019
arw2019 suggested changes Nov 27, 2020
View reviewed changes
Copy link
Member

@arw2019 arw2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skvrahul can you merge master once more & resolve conflict & address @jreback comment? We'll then re-review

doc/source/whatsnew/v1.2.0.rst Outdated Show resolved Hide resolved
arw2019
arw2019 reviewed Nov 29, 2020
View reviewed changes
Copy link
Member

@arw2019 arw2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cc @jreback

@pep8speaks
Copy link

pep8speaks commented Nov 29, 2020 •
edited
Loading

Hello @skvrahul! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-12-08 18:24:25 UTC

@skvrahul
Copy link
Contributor Author

I've resolved conflicts. Should be good to merge with the base branch now.

@skvrahul skvrahul requested a review from arw2019 December 1, 2020 17:51
arw2019
arw2019 reviewed Dec 8, 2020
View reviewed changes
Copy link
Member

@arw2019 arw2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments

pandas/tests/indexes/multi/test_get_set.py Outdated Show resolved Hide resolved
pandas/tests/indexes/multi/test_get_set.py Outdated Show resolved Hide resolved
pandas/tests/indexes/multi/conftest.py Outdated Show resolved Hide resolved
pandas/core/indexes/multi.py Outdated Show resolved Hide resolved
@skvrahul skvrahul requested a review from arw2019 December 8, 2020 07:33
jreback
jreback requested changes Dec 8, 2020
View reviewed changes
doc/source/whatsnew/v1.2.0.rst Outdated Show resolved Hide resolved
pandas/tests/indexes/multi/conftest.py Outdated Show resolved Hide resolved
pandas/tests/indexes/multi/test_get_set.py Outdated Show resolved Hide resolved
@skvrahul skvrahul requested a review from jreback December 8, 2020 19:01
@skvrahul
Copy link
Contributor Author

Made the requested changes and passing all tests. Should be okay to merge now
@jreback @arw2019

@jreback jreback added this to the 1.3 milestone Dec 11, 2020
@jreback jreback merged commit f7e1f94 into pandas-dev:master Dec 11, 2020
@jreback
Copy link
Contributor

jreback commented Dec 11, 2020

thanks @skvrahul very nice!

@gurukiran07 gurukiran07 mentioned this pull request Dec 19, 2020
Closed
2 tasks
@simonjayhawkins simonjayhawkins mentioned this pull request Dec 20, 2020
Merged
5 tasks
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@skvrahul @luckyvs1
ENH: Add MultiIndex.dtypes (pandas-dev#37073)
59ea171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@arw2019 arw2019 Awaiting requested review from arw2019

Assignees
No one assigned
Labels
Enhancement MultiIndex
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

ENH: MultiIndex.dtypes
4 participants
@skvrahul @jreback @pep8speaks @arw2019