-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH/POC: ExtensionIndex for arbitrary EAs #37869
Conversation
I put the question back to you @jorisvandenbossche why would you NOT have an EA Index Class? its makes so much sense |
@jorisvandenbossche I'm aware of your preference. For now I'm just trying to get one fully-working implementation and figure out what testing we need. |
mothballing pending #37367 |
rebased + reopened, but there are a few new test failures locally i still need to track down |
This looks like the key is an int, but arrow seems to think otherwise. Thoughts @jorisvandenbossche ? |
The problem is that |
Makes sense, thanks. im guessing for this POC your suggestion would be requiring 2.0 for these particular tests? |
re-mothballing to clear the queue. needs signficant work in adding tests. |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
Currently 4 tests failing locally bc lib.infer_dtype raises on DecimalArray and JsonArray (xref #37367)
Not remotely enough testing.
cc @jorisvandenbossche