-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement historical finance data from Google Finance #3814
Conversation
def _get_hist_google(sym=None, start=None, end=None, retry_count=3, | ||
pause=0, **kwargs): | ||
""" | ||
Get historical data for the given name from yahoo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
google? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hayd The evils of copy and paste. Corrected
This looks pretty cool! Good to have something in the docs / release notes. |
If this is OK to be merged, I can update the docs (and I might need some help with the release notes) |
It looks pretty good to me, will see what other people think, but ti seems to work. (I tagged it for consideration for 0.11.1). |
Implement historical finance data from Google Finance
Merged. I'll add a release note |
…das use cases, per #3814 and others
…das use cases, per pandas-dev#3814 and others
@gliptak see here for a possible bug...https://travis-ci.org/cpcloud/pandas/jobs/8040142 |
Caused this build to fail too (with the same error I guess) ... https://travis-ci.org/jtratner/pandas/jobs/8035403 |
…das use cases, per pandas-dev#3814 and others
No description provided.