Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement historical finance data from Google Finance #3814

Merged
merged 6 commits into from
Jun 10, 2013
Merged

Implement historical finance data from Google Finance #3814

merged 6 commits into from
Jun 10, 2013

Conversation

gliptak
Copy link
Contributor

@gliptak gliptak commented Jun 8, 2013

No description provided.

def _get_hist_google(sym=None, start=None, end=None, retry_count=3,
pause=0, **kwargs):
"""
Get historical data for the given name from yahoo.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

google? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hayd The evils of copy and paste. Corrected

@hayd
Copy link
Contributor

hayd commented Jun 8, 2013

This looks pretty cool! Good to have something in the docs / release notes.

@gliptak
Copy link
Contributor Author

gliptak commented Jun 9, 2013

If this is OK to be merged, I can update the docs (and I might need some help with the release notes)

@hayd
Copy link
Contributor

hayd commented Jun 9, 2013

It looks pretty good to me, will see what other people think, but ti seems to work.

(I tagged it for consideration for 0.11.1).

wesm added a commit that referenced this pull request Jun 10, 2013
Implement historical finance data from Google Finance
@wesm wesm merged commit 5496613 into pandas-dev:master Jun 10, 2013
@wesm
Copy link
Member

wesm commented Jun 10, 2013

Merged. I'll add a release note

wesm added a commit that referenced this pull request Jun 10, 2013
wesm added a commit that referenced this pull request Jun 10, 2013
jreback pushed a commit to jreback/pandas that referenced this pull request Jun 10, 2013
@cpcloud
Copy link
Member

cpcloud commented Jun 13, 2013

@gliptak see here for a possible bug...https://travis-ci.org/cpcloud/pandas/jobs/8040142

@jtratner
Copy link
Contributor

Caused this build to fail too (with the same error I guess) ... https://travis-ci.org/jtratner/pandas/jobs/8035403

@gliptak
Copy link
Contributor Author

gliptak commented Jun 13, 2013

@cpcloud @jtratner please see #3893

jreback pushed a commit to jreback/pandas that referenced this pull request Oct 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants