CLN: remove internal usage of integer_array()

[jorisvandenbossche]

The integer_array() function stems from a time that pd.array(..) didn't exist yet. But since now pd.array can do this, IMO we shouldn't be using that outside of the integer module (eg I didn't add a floating_array(..)).

Only in tests/arrays/integer/tst_construction.py I still left the usage of integer_array() as is (but probably could also change it there). Could in principle remove the function altogether, since it is just a small wrapper around the private arrays.integer.coerce_to_array

[jreback]

comment + need a whatsnew to mention that we are removing (as experimental totally fine just to do)

[jreback]

shouldn't this be removed?

[jorisvandenbossche]

shouldn't this be removed?

see the top post, this is the only file were I for now kept integer_array (it's used a lot, and it is specifically testing the behaviour of the construction implemented by it). But just changed the import, because I removed it from pandas.core.arrays
Now, as said above, I can further remove it in this file as well (can do that here, or later in another PR)

[jreback]

i would completely remove it in this PR

[jorisvandenbossche]

OK, I removed any remaining usage of integer_array in this file, so could also remove the actual function.

I replaced it with a mixture of pd.array and IntegerArray._from_sequence (and sometimes a parametrized fixture to test both), since they are not exactly equal. For example, with _from_sequence you can also pass it a float array without specifying a dtype, something you can't replicate by only testing pd.array(..)

[jorisvandenbossche]

need a whatsnew to mention that we are removing

This is not public, so no need for a whatnew I think? (I am only removing internal usage, there was no public exposure of this)

[jreback]

need a whatsnew to mention that we are removing

This is not public, so no need for a whatnew I think? (I am only removing internal usage, there was no public exposure of this)

i diagree this has been exposed for a while (in pandas.core.arrays), which is public-ish. i am ok with just removing it, but need to have a note.

[jorisvandenbossche]

pandas.core.arrays is not public. The array classes are exposed, but in pandas.arrays

[jorisvandenbossche]

(anyway, I won't further argue against adding a note if you insist (it's less work to write that sentence than writing this comment ;)), but just want to be clear this is something completely internal)

[jreback]

(anyway, I won't further argue against adding a note if you insist (it's less work to write that sentence than writing this comment ;)), but just want to be clear this is something completely internal)

thanks, i would also completely remove the usage of this as noted above.

[jorisvandenbossche]

Yes, will update test_construction.py to stop using it as well

[jreback]

@jorisvandenbossche i think this is worth putting on 1.2. ping when green.

[jbrockmendel]

can you merge master

[jorisvandenbossche]

i think this is worth putting on 1.2.

Is there a reason to include it for 1.2? (since it's only an internal clean-up)

[jreback]

i think this is worth putting on 1.2.

Is there a reason to include it for 1.2? (since it's only an internal clean-up)

no this is fine for 1.3. thanks