Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF/TYP: Rename ABCIndexClass->ABCIndex and use cast #38329

Merged
merged 4 commits into from
Dec 12, 2020

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@rhshadrach rhshadrach added Refactor Internal refactoring of code Typing type annotations, mypy/pyright type checking labels Dec 6, 2020
@jbrockmendel
Copy link
Member

@rhshadrach can you merge master

@jreback jreback added this to the 1.3 milestone Dec 10, 2020
@jreback
Copy link
Contributor

jreback commented Dec 10, 2020

yep this looks good (just merge master as indicated) and ping on green.

@rhshadrach
Copy link
Member Author

@jreback green.

@jreback jreback merged commit eb67d87 into pandas-dev:master Dec 12, 2020
@jreback
Copy link
Contributor

jreback commented Dec 12, 2020

thanks @rhshadrach

IIRC there was an issue for this? or maybe just a comment

@rhshadrach rhshadrach deleted the abcindex branch December 13, 2020 14:03
@rhshadrach
Copy link
Member Author

To my knowledge this #38055 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants