Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: lighter-weight casting #38377

Merged
merged 1 commit into from
Dec 9, 2020
Merged

CLN: lighter-weight casting #38377

merged 1 commit into from
Dec 9, 2020

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

WillAyd
WillAyd approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - are there other places we can replace this function?

@jbrockmendel
Copy link
Member Author

are there other places we can replace this function?

none as easily as this, but im whittling away

@jreback jreback added this to the 1.3 milestone Dec 9, 2020
@jreback jreback merged commit 93f57e9 into pandas-dev:master Dec 9, 2020
@jbrockmendel jbrockmendel deleted the ref-subarr branch December 9, 2020 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @WillAyd @jreback