-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: inconsistency between frame.any/all with dt64 vs dt64tz #38723
Merged
jreback
merged 13 commits into
pandas-dev:master
from
jbrockmendel:compat-dtlike-reductions
Dec 30, 2020
Merged
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3d160f4
BUG: inconsistency between frame.any/all with dt64 vs dt64tz
jbrockmendel 17b981f
whatsnew
jbrockmendel 64305ef
GH ref
jbrockmendel a293978
typo fixup
jbrockmendel feea775
tpyo fixup
jbrockmendel 6e7809e
Merge branch 'master' of https://github.com/pandas-dev/pandas into co…
jbrockmendel b097c63
Merge branch 'master' into compat-dtlike-reductions
jreback 1b6d8e3
Merge branch 'master' of https://github.com/pandas-dev/pandas into co…
jbrockmendel 249cbf8
Merge branch 'compat-dtlike-reductions' of github.com:jbrockmendel/pa…
jbrockmendel b2e3fd9
Update doc/source/whatsnew/v1.2.1.rst
jbrockmendel d09ff6a
Merge branch 'master' of https://github.com/pandas-dev/pandas into co…
jbrockmendel 4a85ab7
TST: test for Series any/all
jbrockmendel 4e31c96
Merge branch 'master' of https://github.com/pandas-dev/pandas into co…
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1640,6 +1640,17 @@ def floor(self, freq, ambiguous="raise", nonexistent="raise"): | |
def ceil(self, freq, ambiguous="raise", nonexistent="raise"): | ||
return self._round(freq, RoundTo.PLUS_INFTY, ambiguous, nonexistent) | ||
|
||
# -------------------------------------------------------------- | ||
# Reductions | ||
|
||
def any(self, *, axis: Optional[int] = None, skipna: bool = True): | ||
# GH#33478 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a reason why this isn't There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
return nanops.nanany(self._ndarray, axis=axis, skipna=skipna, mask=self.isna()) | ||
|
||
def all(self, *, axis: Optional[int] = None, skipna: bool = True): | ||
# GH#33478 | ||
return nanops.nanall(self._ndarray, axis=axis, skipna=skipna, mask=self.isna()) | ||
|
||
# -------------------------------------------------------------- | ||
# Frequency Methods | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to 1.2.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated+green