Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: make shared includes for describing the datasets in the Getting Started tutorials #38735

Merged
merged 2 commits into from
Dec 30, 2020

Conversation

afeld
Copy link
Member

@afeld afeld commented Dec 27, 2020

Just a refactor; the net result should be the same.

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@afeld afeld changed the title DOC: make a shared include for describing the Titanic data DOC: make a shared include for describing the datasets in the Getting Started tutorials Dec 27, 2020
@afeld
Copy link
Member Author

afeld commented Dec 27, 2020

There's also overlap in the data set descriptions between the combining data and time series tutorials. I wasn't sure which was correct, so didn't touch those.

@afeld afeld changed the title DOC: make a shared include for describing the datasets in the Getting Started tutorials DOC: make shared includes for describing the datasets in the Getting Started tutorials Dec 28, 2020
@afeld afeld changed the title DOC: make shared includes for describing the datasets in the Getting Started tutorials DOC: make shared includes for describing the datasets Dec 28, 2020
@afeld afeld changed the title DOC: make shared includes for describing the datasets DOC: make shared includes for describing the datasets in the Getting Started tutorials Dec 28, 2020
@jreback jreback added this to the 1.3 milestone Dec 30, 2020
@jreback jreback merged commit f44f3ec into pandas-dev:master Dec 30, 2020
@jreback
Copy link
Contributor

jreback commented Dec 30, 2020

thanks @afeld. pls check that this renders nicely in the built docs: https://pandas.pydata.org/pandas-docs/dev/

<a href="https://github.com/pandas-dev/pandas/tree/master/doc/data/air_quality_no2.csv" class="btn btn-dark btn-sm">To raw data</a>
</div>
</div>
. include:: air_quality_no2.rst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a missing second dot here, I think (at the beginning of the line)

Copy link
Member Author

@afeld afeld Dec 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to stop making pull requests when sleep deprived 🤦 Sorry! Fixed in #38839.

<a href="https://github.com/pandas-dev/pandas/tree/master/doc/data/air_quality_no2.csv" class="btn btn-dark btn-sm">To raw data</a>
</div>
</div>
. include:: air_quality_no2.rst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here as well

luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants