TST: use frame_or_series for some tz_localize/tz_convert tests #38756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Dec 28, 2020
| import pandas._testing as tm | ||
|
|
||
|
|
||
| class TestTZConvert: | ||
| def test_frame_tz_convert(self): | ||
| def test_tz_convert(self, frame_or_series): |
There was a problem hiding this comment.
any appetite for moving these shared tests back to generic/methods? or else we just document that they are always in the frame/ tests?
There was a problem hiding this comment.
last time we discussed this we were leaning towards getting rid of generic/methods and moving those back to frame/methods
There was a problem hiding this comment.
yeah totally fine. agreed generic is not a great place. just let's document that's where we have combined tests (doesn't have to be here).
There was a problem hiding this comment.
the test org document we made a couple months ago says that frame_or_series tests go in with the frame tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff