TST: GH30999 add match=msg to all pytest.raises in pandas/tests/window #38804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Error Reporting
jreback
reviewed
Dec 30, 2020
| @@ -44,7 +44,7 @@ def f(x): | |||
| expected = df.iloc[2:].reindex_like(df) | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
| with pytest.raises(AttributeError): | |||
| with tm.external_error_raised(AttributeError): | |||
There was a problem hiding this comment.
AttributeError: 'numpy.ndarray' object has no attribute 'index' in both cases
There was a problem hiding this comment.
I suppose from a numpy array not having an index attribute
There was a problem hiding this comment.
hmm. i think we could raise a better message here as to what the issue is (trying to use pandas functions inside the rolling when raw=True). cc @mroeschke let me create an issue.
|
thanks @moink |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request partially addresses xref #30999 to remove bare
pytest.raisesby addingmatch=msg. It doesn't close that issue as I have only addressed test modules in the pandas/tests/window/ directory.I have added
match=msgto 3 instances ofpytest.raisesand converted another to atm.external_error_raised. Nothing complicated or controversial, imo.black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff