Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: GH30999 Change all pytest.raises in pandas/tests/indexing to tm.external_error_raised #38825

Merged

Conversation

moink
Copy link
Member

@moink moink commented Dec 30, 2020

Addresses xref #30999 for pandas/tests/indexing by changing three bare pytest.raise instances to tm.external_error_raised

This is the last of the simpler PRs for #30999 - after that it gets more complex.

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

pandas/tests/indexing/multiindex/test_partial.py Outdated Show resolved Hide resolved
pandas/tests/indexing/test_coercion.py Outdated Show resolved Hide resolved
@jreback jreback added the Code Style Code style, linting, code_checks label Dec 30, 2020
@jreback jreback added this to the 1.3 milestone Dec 30, 2020
@jreback jreback added the Testing pandas testing functions or related to the test suite label Dec 30, 2020
@jreback jreback merged commit dd52445 into pandas-dev:master Dec 31, 2020
@jreback
Copy link
Contributor

jreback commented Dec 31, 2020

thanks @moink

luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants