TST: GH30999 address all bare pytest.raises in pandas/tests/arrays/boolean/test_arithmetic.py #38849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Dec 31, 2020
| @@ -46,7 +46,7 @@ def test_add_mul(left_array, right_array, opname, exp): | |||
|
|
|||
|
|
|||
| def test_sub(left_array, right_array): | |||
| with pytest.raises(TypeError): | |||
| with tm.external_error_raised(TypeError): | |||
There was a problem hiding this comment.
hmm i actually think showing these errors would be good. yes they might be external, but these are important to see.
jreback
reviewed
Dec 31, 2020
| @@ -46,8 +47,11 @@ def test_add_mul(left_array, right_array, opname, exp): | |||
|
|
|||
|
|
|||
| def test_sub(left_array, right_array): | |||
| with pytest.raises(TypeError): | |||
| # numpy points to ^ operator or logical_xor function instead | |||
| msg = re.escape( | |||
There was a problem hiding this comment.
ok great. yeah these are expected. i don't like the external_ thing because it is not obvious what is happening.
There was a problem hiding this comment.
I don't like it much either but it's what the guidance in the issue says to do. shrug
There was a problem hiding this comment.
hah, that's why I look at all the PRs :->
…ecated" instead of "not supported"
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
…olean/test_arithmetic.py (pandas-dev#38849)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #30999 I thought I was done with the simple bare
pytest.raiseinstances but I somehow missed this test module. Four instances, three fixed by addingmatchand one by usingtm.external_error_raisedbecause I believe the error comes from numpy.black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff