TST: GH30999 address all bare pytest.raises in pandas/tests/series and add EMPTY_STRING_PATTERN to tm #38855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d add EMPTY_STRING_PATTERN to tm
|
thanks |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
…d add EMPTY_STRING_PATTERN to tm (pandas-dev#38855)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address xref #30999 in pandas/tests/series
Three of the four errors raised within
pytest.raiseswere forNotImplementedErrorwith the empty string as the error message. Rather than individually making a regular expression for the empty string, I added one as a constant topandas/_testing/__init__.py. There are two more similar cases in other modules so I wanted to put it somewhere that all the testing modules import. But if you don't like it I can revert it and instead use an individual empty string pattern in each case.black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff