Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: GH30999 add match=msg to 2 pytest.raises in pandas/tests/io/json/test_normalize.py #38864

Conversation

moink
Copy link
Member

@moink moink commented Dec 31, 2020

xref #30999 for pandas/tests/io/json/test_normalize.py

And with this my work on #30999 is done. Will head over to the issue to explain why I am not fixing the remaining 15 instances of pytest.raise

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback jreback added the Code Style Code style, linting, code_checks label Jan 1, 2021
@jreback jreback added this to the 1.3 milestone Jan 1, 2021
@jreback
Copy link
Contributor

jreback commented Jan 1, 2021

@github-actions precommit

@jreback
Copy link
Contributor

jreback commented Jan 1, 2021

actually its the ci/checks. @moink pls fixup when you can

@moink
Copy link
Member Author

moink commented Jan 1, 2021

Hmm I believe the check is saying that one test is using pytest.raises but not as a context manager. That's not actually true - I think it's a false positive, it's just a slightly weird structure of passing in a context manager as an argument.

I will see about restructuring the test so it doesn't give that error anymore. Is it a new check? Because it's not a new structure.

@jreback jreback merged commit ff05fff into pandas-dev:master Jan 1, 2021
@jreback
Copy link
Contributor

jreback commented Jan 1, 2021

thanks @moink

luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants